Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1134219628
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##########
@@ -763,7 +783,7 @@ CatalogBaseTable instantiateCatalogTable(Table hiveTable) {
tableSchemaProps.putProperties(properties);
// try to get table schema with both new and old (1.10) key, in
order to support tables
// created in old version
- tableSchema =
+ TableSchema tableSchema =
Review Comment:
I think its doesn't matter. Since we still use the `DescriptorProperties` to
se/de the schema to store/restore to the external meta store. So `TableSchema`
actually still used in the hive connector system. It can be entirely removed
after we can use the new way to se/de the schema. But I think we can improve it
as a follow up. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
