lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1447612921
> Hi, I just found we have made this change. I have a question: how do we obtain the corresponding input stream for each GraphNode in the GraphModel? modelDataInputs are linearly organized, but GraphNode are in a form of DAG. > It seems additional parameters are required in the signature of setModelData to help map InputStreams to GraphNodes. @Fanoid we will need to add extra APIs in GraphBuilder and extra class GraphModelServable in order to compose multiple Estimator/Transformer into one Servable. We can obtain the input stream for `ModelServable#setModelData` similar to how the existing `GraphBuilder` obtain input streams for `Model#setModelData`. The high level idea is to use placeholder to provide this information to GraphBuilder. Maybe checkout `testGraphWithSetGetModelData()` [1] for example. [1] https://github.com/apache/flink-ml/blob/master/flink-ml-core/src/test/java/org/apache/flink/ml/api/GraphTest.java#L213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
