Fanoid commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1447574309
> > > It seems additional parameters are required in the signature of setModelData to help map InputStreams to GraphNodes. > > IMO, indeed we need to map `InputStream`s to `GraphNode`s, but it is implementation, not required in API. The existing `GraphModel` class has shown a way to implement it. If not specifying the mapping in this method, we may need another public API to obtain the orders of `GraphNode`s. Otherwise, end-users can't figure out how to put the model data of all `GraphNode`s into an array/list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
