[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #550: [FLINK-31178] Public Writer API

[via GitHub]

SteNicholas commented on code in PR #550:
URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1118569463


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/FileStoreTable.java:
##########
@@ -55,9 +56,10 @@ default List<String> partitionKeys() {
     FileStoreTable copy(Map<String, String> dynamicOptions);
 
     @Override
-    default BucketComputer bucketComputer() {
-        return new BucketComputer(schema());
-    }
+    TableWriteImpl<?> newWrite(String commitUser);
+
+    @Override
+    TableCommitImpl newCommit(String commitUser);

Review Comment:
   ```suggestion
       TableCommitImpl<?> newCommit(String commitUser);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org