SteNicholas commented on code in PR #550:
URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1118561122
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java:
##########
@@ -54,10 +54,10 @@
/**
* Prepare for a commit.
*
- * @param blocking if this method need to wait for current compaction to
complete
+ * @param waitCompaction if this method need to wait for current
compaction to complete
* @return Incremental files in this snapshot cycle
*/
- CommitIncrement prepareCommit(boolean blocking) throws Exception;
+ CommitIncrement prepareCommit(boolean waitCompaction) throws Exception;
Review Comment:
IMO, the `waitCompaction` has nothing to do with `prepareCommit`. On other
words, the `compaction` operation should not be associated with the commit
operation at the interface definition level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
