fsk119 commented on code in PR #21945: URL: https://github.com/apache/flink/pull/21945#discussion_r1112507939
########## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerDeTest.java: ########## @@ -219,6 +231,25 @@ private static List<LogicalType> generateTestData() { // ignore nullable for NullType testTypes.add(new NullType()); + // interval types + testTypes.add(new YearMonthIntervalType(YearMonthIntervalType.YearMonthResolution.MONTH)); Review Comment: We should move the cases into the `types`. In line 225, we will create test cases with or without nullbility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org