snuyanzin commented on code in PR #21945:
URL: https://github.com/apache/flink/pull/21945#discussion_r1111855663
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerializer.java:
##########
@@ -87,6 +89,10 @@ public final class LogicalTypeJsonSerializer extends
StdSerializer<LogicalType>
public static final String FIELD_NAME_CLASS = "class";
public static final String FIELD_NAME_SERIALIZER = "serializer";
+ // INTERVAL
Review Comment:
From one side I'm ok to add `upper/lowerResolution`
however from another side current ser/de is based on `LogicalTypeRoot`. And
`INTERVAL` is NOT a `LogicalTypeRoot`... it is just a `LogicalTypeFamily`. So
it will require extra parsing to differentiate between `YearMonthIntervalType`
and `DayTimeIntervalType`.
Or am I missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
