dawidwys commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1081243028
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerSnapshot.java:
##########
@@ -56,6 +55,9 @@
/** Contains the actual content for the serializer snapshot. */
private PojoSerializerSnapshotData<T> snapshotData;
+ /** Configuration of the current execution. */
+ private ExecutionConfig executionConfig;
Review Comment:
This is a serious issue :(
We should not do that ever! This gives an impression the `executionConfig`
is part of the serialized snapshot which it **must** not!
If I understand correctly this is necessary, because the method
`resolveSchemaCompatibility(TypeSerializerSnapshot<T> oldSerializerSnapshot` is
called at a point where the originating `newSerializer` has not been used yet
and thus has not registeredSubclassSerializers.
We need to fix it in a different way. The current approach makes it even
messier than it already is and we can not go with that approach.
I'll give it a thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
