masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1084777905
##########
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializerSnapshot.java:
##########
@@ -76,10 +80,26 @@ protected void readOuterSnapshot(
this.componentClass = InstantiationUtil.resolveClassByName(in,
userCodeClassLoader);
}
+ @Override
+ public TypeSerializerSchemaCompatibility<C[]> resolveSchemaCompatibility(
+ TypeSerializerSnapshot<C[]> oldSerializerSnapshot) {
+ if (oldSerializerSnapshot instanceof
GenericArraySerializerConfigSnapshot) {
Review Comment:
You are right.
I have added
CompositeTypeSerializerUpgradeTest#testUpgradeFromDeprecatedSnapshot to test it.
BTW, I have a minor problem.
TypeSerializerUpgradeTestBase seems just to test upgradation from Flink
Version 1.11 ?
IIUC, TypeSerializer should supports Flink Version from 1.8 currently.
Should we need to make it test from 1.8 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
