nowke commented on code in PR #487:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1059562798
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java:
##########
@@ -248,13 +252,40 @@ public void testValidationWithoutDefaultConfig() {
testError(
dep ->
dep.getSpec().getJobManager().getResource().setMemory("invalid"),
"JobManager resource memory parse error");
-
testError(
dep ->
dep.getSpec().getTaskManager().getResource().setMemory(null),
- "TaskManager resource memory must be defined");
+ "TaskManager memory configuration failed");
Review Comment:
It is thrown by `IllegalConfigurationException` -
[JobManagerProcessUtils.java#L7](https://github.com/apache/flink/blob/5c3658aa06b79e8039043145560a1ad2bcce68b0/flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerProcessUtils.java#L78)
Full error message is very descriptive, example:
```
TaskManager memory configuration failed: Either required fine-grained memory
(taskmanager.memory.task.heap.size and taskmanager.memory.managed.size),
or Total Flink Memory size (Key: 'taskmanager.memory.flink.size' , default:
null (fallback keys: [])),
or Total Process Memory size (Key: 'taskmanager.memory.process.size' ,
default: null (fallback keys: [])) need to be configured explicitly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
