gyfora commented on code in PR #487:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1059629736
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java:
##########
@@ -248,13 +252,40 @@ public void testValidationWithoutDefaultConfig() {
testError(
dep ->
dep.getSpec().getJobManager().getResource().setMemory("invalid"),
"JobManager resource memory parse error");
-
testError(
dep ->
dep.getSpec().getTaskManager().getResource().setMemory(null),
- "TaskManager resource memory must be defined");
+ "TaskManager memory configuration failed");
Review Comment:
In this case I would expect an error instructing the user to set
`spect.taskmanager.resource.memory` instead of the flink configs directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
