luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1059211343
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/CompactFileUtils.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.table.batch.compact; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.table.stream.compact.CompactContext; +import org.apache.flink.connector.file.table.stream.compact.CompactReader; +import org.apache.flink.connector.file.table.stream.compact.CompactWriter; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** Utils for compacting files. */ +public class CompactFileUtils { + + private static final Logger LOG = LoggerFactory.getLogger(CompactFileUtils.class); + + /** + * Do Compaction: - Target file exists, do nothing. Otherwise, it'll read the input files and + * write the target file to achieve compaction purpose. + */ + public static <T> Path doCompact( + FileSystem fileSystem, + String partition, + List<Path> paths, + Path target, + Configuration config, + CompactReader.Factory<T> readerFactory, + CompactWriter.Factory<T> writerFactory) + throws IOException { + if (paths.size() == 0) { + return null; + } + + if (fileSystem.exists(target)) { Review Comment: In current implementation for `BatchCompactOperator` , since the target path will always a different path whenever if's fail over or differenet attempts in speculative execution. I perfer to keep the logic in CompactFileUitls since it's like a general method without any other assumption and it's designed to return the target path directly if the target path exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
