luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058901029
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.table.batch.compact; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.table.CompactFileUtils; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CompactOutput; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CompactionUnit; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CoordinatorOutput; +import org.apache.flink.connector.file.table.stream.compact.CompactReader; +import org.apache.flink.connector.file.table.stream.compact.CompactWriter; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.state.StateInitializationContext; +import org.apache.flink.streaming.api.operators.AbstractStreamOperator; +import org.apache.flink.streaming.api.operators.BoundedOneInput; +import org.apache.flink.streaming.api.operators.OneInputStreamOperator; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.util.function.SupplierWithException; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * CompactOperator for compaction in batch mode. It will compact files to a target file and then + * emit the compacted file's path to downstream operator. The main logic is similar to {@link + * org.apache.flink.connector.file.table.stream.compact.CompactOperator} but skip some unnecessary + * operations in batch mode. + */ +public class BatchCompactOperator<T> extends AbstractStreamOperator<CompactOutput> + implements OneInputStreamOperator<CoordinatorOutput, CompactOutput>, BoundedOneInput { + + private static final long serialVersionUID = 1L; + + private final SupplierWithException<FileSystem, IOException> fsFactory; + private final CompactReader.Factory<T> readerFactory; + private final CompactWriter.Factory<T> writerFactory; + + private transient FileSystem fileSystem; + private transient Map<String, List<Path>> compactedFiles; + + public BatchCompactOperator( + SupplierWithException<FileSystem, IOException> fsFactory, + CompactReader.Factory<T> readerFactory, + CompactWriter.Factory<T> writerFactory) { + this.fsFactory = fsFactory; + this.readerFactory = readerFactory; + this.writerFactory = writerFactory; + } + + @Override + public void initializeState(StateInitializationContext context) throws Exception { Review Comment: Yes. I think put it in `initializeState` is more consistent to existing code. e.g, CompactCoordinator also init in `initializeState` method. ########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactCoordinator.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.table.batch.compact; + +import org.apache.flink.connector.file.table.BinPacking; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CompactionUnit; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CoordinatorInput; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.CoordinatorOutput; +import org.apache.flink.connector.file.table.stream.compact.CompactMessages.InputFile; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.state.StateInitializationContext; +import org.apache.flink.streaming.api.operators.AbstractStreamOperator; +import org.apache.flink.streaming.api.operators.BoundedOneInput; +import org.apache.flink.streaming.api.operators.OneInputStreamOperator; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.util.function.SupplierWithException; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; + +/** + * Coordinator for compaction in batch mode. It will collect the written files in {@link + * BatchFileWriter} and determine whether to compact files or not as well as what files should be + * merged into a single file. + */ +public class BatchCompactCoordinator extends AbstractStreamOperator<CoordinatorOutput> + implements OneInputStreamOperator<CoordinatorInput, CoordinatorOutput>, BoundedOneInput { + + private static final long serialVersionUID = 1L; + + private final SupplierWithException<FileSystem, IOException> fsFactory; + private final long compactAverageSize; + private final long compactTargetSize; + + private transient FileSystem fs; + // the mapping from written partitions to the corresponding files. + private transient Map<String, List<Path>> inputFiles; + + public BatchCompactCoordinator( + SupplierWithException<FileSystem, IOException> fsFactory, + long compactAverageSize, + long compactTargetSize) { + this.fsFactory = fsFactory; + this.compactAverageSize = compactAverageSize; + this.compactTargetSize = compactTargetSize; + } + + @Override + public void initializeState(StateInitializationContext context) throws Exception { + super.initializeState(context); Review Comment: dito. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
