[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548044#comment-15548044 ]
ASF GitHub Bot commented on FLINK-4329: --------------------------------------- GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2593 [FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling This is a quick fix for the [FLINK-4329] issue. The fix on the master is different but it contains more changes that are not easy to back-port to 1.1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink injestion_fix_1.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2593 ---- commit 79d48e77b4a9c8a8eaf4e1e3199e2787deebab63 Author: kl0u <kklou...@gmail.com> Date: 2016-10-04T13:27:59Z [FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling ---- > Fix Streaming File Source Timestamps/Watermarks Handling > -------------------------------------------------------- > > Key: FLINK-4329 > URL: https://issues.apache.org/jira/browse/FLINK-4329 > Project: Flink > Issue Type: Bug > Components: Streaming Connectors > Affects Versions: 1.1.0 > Reporter: Aljoscha Krettek > Assignee: Kostas Kloudas > Fix For: 1.2.0, 1.1.3 > > > The {{ContinuousFileReaderOperator}} does not correctly deal with watermarks, > i.e. they are just passed through. This means that when the > {{ContinuousFileMonitoringFunction}} closes and emits a {{Long.MAX_VALUE}} > that watermark can "overtake" the records that are to be emitted in the > {{ContinuousFileReaderOperator}}. Together with the new "allowed lateness" > setting in window operator this can lead to elements being dropped as late. > Also, {{ContinuousFileReaderOperator}} does not correctly assign ingestion > timestamps since it is not technically a source but looks like one to the > user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)