gaborgsomogyi commented on PR #21247: URL: https://github.com/apache/flink/pull/21247#issuecomment-1308681238
* Some have still timeouts included (e.g. [KafkaSinkITCase:438](https://github.com/apache/flink/blob/e95897694d59126d1949a7f2337bcc3b7ce49747/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java#L438) and [KafkaSinkITCase:432](https://github.com/apache/flink/blob/e95897694d59126d1949a7f2337bcc3b7ce49747/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java#L432), [KafkaSinkExternalContext:118](https://github.com/apache/flink/blob/025675725336cd572aa2601be525efd4995e5b84/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/testutils/KafkaSinkExternalContext.java#L118), ...) I've removed timeouts here too. * No special error handling (e.g. [KafkaEnumeratorTest:217](https://github.com/apache/flink/blob/e95897694d59126d1949a7f2337bcc3b7ce49747/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java#L217)) I think w/o deep understand what was the intention there I wouldn't change anything so leaving that as-is was intentional. W/o super deep consideration I would say we're not intended to test Kafka topic delete functionality. If topic can be created/modified and Flink is able to process the data, then we're fine. In my view we need a full concept w/ in-depth consideration to do proper refactoring in this area (I mean Kafka server/Consumer/Producer/AdminClient/Topic lifecycle). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
