gaborgsomogyi commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1017857996
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableTestBase.java:
##########
@@ -135,8 +134,16 @@ public void createTestTopic(String topic, int
numPartitions, int replicationFact
properties.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG,
getBootstrapServers());
try (AdminClient admin = AdminClient.create(properties)) {
admin.createTopics(
- Collections.singletonList(
- new NewTopic(topic, numPartitions, (short)
replicationFactor)));
+ Collections.singletonList(
+ new NewTopic(topic, numPartitions, (short)
replicationFactor)))
+ .all()
+ .get();
+ } catch (Exception e) {
+ throw new IllegalStateException(
Review Comment:
I would leave it in the beautification phase. I think it would be good to
fix a 1+ year issue. Pretty sure several hundred CI and dev hours we can spare
by letting beautification for later :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
