Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2517#discussion_r80479173
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
 ---
    @@ -219,9 +249,16 @@ public ScopeFormats getScopeFormats() {
        public void register(Metric metric, String metricName, MetricGroup 
group) {
                try {
                        if (reporters != null) {
    -                           for (MetricReporter reporter : reporters) {
    +                           for (int i = 0; i < reporters.size(); i++) {
    +                                   MetricReporter reporter = 
reporters.get(i);
                                        if (reporter != null) {
    -                                           
reporter.notifyOfAddedMetric(metric, metricName, group);
    +                                           if (group instanceof 
AbstractMetricGroup) {
    +                                                   FrontMetricGroup front 
= groups.get(i);
    --- End diff --
    
    just realized that we can simplify this. We don't need multiple 
FrontMetricGroups, but only 1 on which we also set the index before notify().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to