Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240197
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -99,10 +99,17 @@ public MetricRegistry(Configuration config) {
DelegatingConfiguration reporterConfig = new
DelegatingConfiguration(config, ConfigConstants.METRICS_REPORTER_PREFIX +
namedReporter + ".");
final String className =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX, null);
if (className == null) {
- LOG.error("No reporter class set for
reporter " + namedReporter + ". Metrics might not be exposed/reported.");
+ LOG.error("No reporter class set for
reporter {}. Metrics might not be exposed/reported.",namedReporter);
continue;
}
+ String delimiterForReporter =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,defaultDelimiter);
+ if(delimiterForReporter.length()!=1){
+ LOG.warn("Failed to parse delimiter for
reporter {}, using global delimiter.",namedReporter);
+ delimiterForReporter=".";
+ }
+
this.delimiters.add(delimiterForReporter.charAt(0));
+
--- End diff --
Please add the configured delimiter to the info log message when a reporter
was instantiated. (near the end of the constructor)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
