syhily commented on code in PR #20725:
URL: https://github.com/apache/flink/pull/20725#discussion_r966051977


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarUnorderedPartitionSplitReader.java:
##########
@@ -147,7 +136,11 @@ protected void afterCreatingConsumer(PulsarPartitionSplit 
split, Consumer<byte[]
         }
     }
 
-    public PulsarPartitionSplitState snapshotState(long checkpointId) {
+    public Optional<PulsarPartitionSplitState> snapshotState(long 
checkpointId) {

Review Comment:
   Yep. I just keep this for backward compatible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to