JingsongLi commented on code in PR #280:
URL: https://github.com/apache/flink-table-store/pull/280#discussion_r959229043
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/KeyValueFileStoreRead.java:
##########
@@ -50,13 +60,18 @@
*/
public class KeyValueFileStoreRead implements FileStoreRead<KeyValue> {
+ private final TableSchema tableSchema;
private final DataFileReader.Factory dataFileReaderFactory;
private final Comparator<RowData> keyComparator;
private final MergeFunction mergeFunction;
+ private final boolean valueCountMode;
+ private final FieldStatsArraySerializer rowStatsConverter;
+
+ @Nullable private int[][] keyProjectedFields;
- private int[][] keyProjectedFields;
+ @Nullable private List<Predicate> keyFilters;
- private List<Predicate> filters;
+ @Nullable private List<Predicate> allFilters;
Review Comment:
Introduce two filter:
```
private List<Predicate> overlappedFilters;
private List<Predicate> nonOverlappedFilters;
```
So in the `createReader`, there is no need to judge `acceptAllFilter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
