JingsongLi commented on code in PR #280:
URL: https://github.com/apache/flink-table-store/pull/280#discussion_r958013297
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/KeyValueFileStoreRead.java:
##########
@@ -87,15 +94,28 @@ public KeyValueFileStoreRead withValueProjection(int[][]
projectedFields) {
@Override
public FileStoreRead<KeyValue> withFilter(Predicate predicate) {
- this.filters = splitAnd(predicate);
+ this.keyFilters = splitAnd(predicate);
+ return this;
+ }
+
+ public FileStoreRead<KeyValue> withValueFilter(Predicate predicate) {
+ this.valueFilters = splitAnd(predicate);
return this;
}
@Override
public RecordReader<KeyValue> createReader(Split split) throws IOException
{
+ List<List<SortedRun>> sections =
+ new IntervalPartition(split.files(),
keyComparator).partition();
if (split.isIncremental()) {
- DataFileReader dataFileReader =
- dataFileReaderFactory.create(split.partition(),
split.bucket(), true, filters);
+ boolean keyRangeOverlap = false;
+ for (List<SortedRun> section : sections) {
Review Comment:
Maybe we can just filter all for incremental?
Because incremental does not have a merge when it is read, it seems that it
is OK to directly filter and push down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
