reswqa commented on code in PR #20553: URL: https://github.com/apache/flink/pull/20553#discussion_r948742965
########## flink-core/src/main/java/org/apache/flink/util/concurrent/DirectExecutorService.java: ########## @@ -28,16 +28,17 @@ import java.util.concurrent.Callable; import java.util.concurrent.CancellationException; import java.util.concurrent.ExecutionException; -import java.util.concurrent.ExecutorService; import java.util.concurrent.Future; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.ScheduledFuture; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; /** - * The direct executor service directly executes the runnables and the callables in the calling - * thread. + * The direct scheduled executor service directly executes the runnables and the callables in the + * calling thread. */ -class DirectExecutorService implements ExecutorService { +class DirectExecutorService implements ScheduledExecutorService { Review Comment: Good suggestion, changed those tests to use a real scheduled executor service and revert the changing of `DirectExecutorService `. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org