xintongsong commented on code in PR #20553:
URL: https://github.com/apache/flink/pull/20553#discussion_r948725837
##########
flink-core/src/main/java/org/apache/flink/util/concurrent/DirectExecutorService.java:
##########
@@ -28,16 +28,17 @@
import java.util.concurrent.Callable;
import java.util.concurrent.CancellationException;
import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
/**
- * The direct executor service directly executes the runnables and the
callables in the calling
- * thread.
+ * The direct scheduled executor service directly executes the runnables and
the callables in the
+ * calling thread.
*/
-class DirectExecutorService implements ExecutorService {
+class DirectExecutorService implements ScheduledExecutorService {
Review Comment:
I'm not sure about changing `DirectExecutorService`. The only reason I see
for this change is that some shuffle test cases are using
`Executors#newDirectExecutorService`. This also indicates that the code path
for scheduling executions are never covered. Alternatively, we can make those
tests to use a real scheduled executor service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
