imaffe commented on code in PR #20567:
URL: https://github.com/apache/flink/pull/20567#discussion_r946332754


##########
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderTestBase.java:
##########
@@ -198,7 +213,7 @@ void 
pollMessageAfterTimeout(PulsarPartitionSplitReaderBase<String> splitReader)
         String topicName = randomAlphabetic(10);
 
         // Add a split
-        seekStartPositionAndHandleSplit(splitReader, topicName, 0);
+        handleSplit(splitReader, topicName, 0, MessageId.latest);

Review Comment:
   Here we should use seekStartPositionAndHandleSplit(). The difference is 
whether we want to do a seek before we call handleSplitChanges. Here we want to 
receive 0 message in the next poll() call, so we need to seek to the `latest` 
cursor so no data will be consumed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to