lindong28 commented on code in PR #20454:
URL: https://github.com/apache/flink/pull/20454#discussion_r941393652


##########
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##########
@@ -282,7 +331,11 @@ public void resetToCheckpoint(long checkpointId, @Nullable 
byte[] checkpointData
             mainThreadExecutor.assertRunningInMainThread();
         }
 
+        abortAllPendingAcknowledgeCloseGatewayFutures(
+                "The coordinator has been reset to checkpoint " + 
checkpointId);
         
subtaskGatewayMap.values().forEach(SubtaskGatewayImpl::openGatewayAndUnmarkCheckpoint);
+        latestAttemptedCheckpointId = Math.max(latestAttemptedCheckpointId, 
checkpointId);

Review Comment:
   Should we use `latestAttemptedCheckpointId = checkpointId` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to