simplejason commented on code in PR #20380:
URL: https://github.com/apache/flink/pull/20380#discussion_r933797678


##########
flink-runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.less:
##########
@@ -17,50 +17,56 @@
  */
 @import "theme";
 
-nz-card {
-  ::ng-deep {
-    .ant-card-head {
-      border-bottom: 0;
-    }
+:host {
+  nz-card {
+    ::ng-deep {
+      .ant-card-head {
+        border-bottom: 0;
+      }
 
-    .ant-card-body {
-      padding: 0 24px 8px;
+      .ant-card-body {
+        padding: 0 24px 8px;
+      }
     }
   }
-}
 
-.total {
-  color: @success-color;
-  font-size: 36px;
-  line-height: 38px;
-}
-
-.footer {
-  margin-top: 16px;
-  padding-top: 9px;
-  border-top: 1px solid @border-color-split;
+  .total {
+    color: @success-color;
+    font-size: 36px;
+    line-height: 38px;
+  }
 
-  .field {
-    display: inline-block;
-    font-size: 14px;
-    line-height: 22px;
+  .footer {
+    margin-top: @margin-md;
+    padding-top: @padding-sm;
+    border-top: 1px solid @border-color-split;

Review Comment:
   nit: I'd like to use variables like `@border-width-base` .etc. to make the 
code style uniform :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to