[GitHub] [flink] simplejason commented on a diff in pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

[GitBox]

simplejason commented on code in PR #20380:
URL: https://github.com/apache/flink/pull/20380#discussion_r933797173


##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html:
##########
@@ -63,9 +63,18 @@
   </thead>
   <tbody>
     <ng-template nz-virtual-scroll let-data>
-      <ng-container *ngIf="narrowLogData(data) as subtask">
+      <ng-container *ngIf="narrowType(data) as subtask">
         <tr>
-          <td>{{ subtask['subtask'] }}</td>
+          <td
+            [nzShowExpand]="subtask['other-concurrent-attempts']?.length > 0"
+            [nzExpand]="expandSet.has(subtask['subtask'])"
+            (nzExpandChange)="onExpandChange(subtask, $event)"
+          >
+            {{ subtask['subtask'] }}
+            <ng-container *ngIf="subtask['attempt-number'] !== undefined">
+              &nbsp;[attempt-{{ subtask['attempt-number'] + 1 }}]

Review Comment:
   nit: I think it's better to use `padding` or `margin` instead of `&nbsp;`, 
but it's a problem :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org