weibozhao commented on code in PR #131: URL: https://github.com/apache/flink-ml/pull/131#discussion_r931902284
########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorslicer/VectorSlicerParams.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.feature.vectorslicer; + +import org.apache.flink.ml.common.param.HasInputCol; +import org.apache.flink.ml.common.param.HasOutputCol; +import org.apache.flink.ml.param.IntArrayParam; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; + +/** + * Params of {@link VectorSlicer}. + * + * @param <T> The class type of this instance. + */ +public interface VectorSlicerParams<T> extends HasInputCol<T>, HasOutputCol<T> { + Param<Integer[]> INDICES = + new IntArrayParam( + "indices", + "An array of indices to select features from a vector column.", + null, + ParamValidators.numericalArrayGtEq(0)); Review Comment: I think one validator can not do all the checks of this parameter. We just do some checks. The duplicated check may be done in the algorithm code. The common validator only do one kind of checks. We can do the other checks in some other place, just like the begin of the algorithm. I have add a `checkIndices()` to check the duplicated indices and empty array. If we put all the checks in one param validator, the validator maybe only can be used by VectorSlicer. What do you think about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
