yunfengzhou-hub commented on code in PR #131:
URL: https://github.com/apache/flink-ml/pull/131#discussion_r925345067
##########
flink-ml-core/src/main/java/org/apache/flink/ml/param/ParamValidators.java:
##########
@@ -38,6 +38,22 @@ public static <T> ParamValidator<T> gtEq(double lowerBound) {
return (value) -> value != null && ((Number) value).doubleValue() >=
lowerBound;
}
+ // Checks if all values in the parameter intArray is greater than or equal
to lowerBound.
+ public static <T> ParamValidator<T> intArrayGtEq(double lowerBound) {
+ return value -> {
Review Comment:
We agreed during an offline discussion that
`ParamValidators.numericalArrayGtEq(0)` is a proper solution. For similar
discussions we can directly refer to existing practices, like that in Alink or
Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
