XComp commented on code in PR #19968:
URL: https://github.com/apache/flink/pull/19968#discussion_r901587633
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java:
##########
@@ -377,6 +378,7 @@ void
testOnGloballyTerminalStateWaitsForSavepointCompletion() throws Exception {
ctx.setStopWithSavepoint(sws);
sws.onGloballyTerminalState(JobStatus.FINISHED);
+ // this is a sanity check that we haven't scheduled a state
transition
Review Comment:
there's another location in
`testConcurrentSavepointFailureAndGloballyTerminalStateCauseRestart` (see [line
407](https://github.com/apache/flink/blob/106b83b88a1dab577b2f60b5a9dc8052526d3820/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java#L407))
where we could add the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
