zentol commented on PR #19833: URL: https://github.com/apache/flink/pull/19833#issuecomment-1152409972
That's a good question; they could definitely share it if we wanted to. It would result in `table-code-splitter` having a new dependency on `table-common` (presumably, if we move that method there; seems like the only viable spot). I don't think this would be a problem dependency-wise, because the only user of table-code-splitter is table-runtime, which also depends on `table-common`. Maybe this wasn't done intentionally so that `table-code-splitter` remains self-contained w.r.t. the rest of the table modules; I'm not sure. I don't think they necessarily must use the same naming scheme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
