zentol commented on code in PR #19586:
URL: https://github.com/apache/flink/pull/19586#discussion_r893627065
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -106,6 +106,8 @@
private static final int MAX_CONNECTION_RETRY = 3;
private static final long CONNECTION_RETRY_DELAY = 500L;
+ private static final int WRITE_TIMEOUT = 10;
Review Comment:
unused
##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -36,9 +36,11 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
- <cassandra.version>2.2.5</cassandra.version>
- <driver.version>3.0.0</driver.version>
- <guava.version>18.0</guava.version>
+ <!-- Cassandra version 4.x allow to address clusters of version
3.x as well -->
+ <cassandra.version>4.0.3</cassandra.version>
+ <!--driver 3.x works with 3.x and 4.x versions of Cassandra but
driver 4.x is a complete refactoring with different API-->
+ <driver.version>3.11.2</driver.version>
Review Comment:
The dependency tree got quite a bit larger.
There's some native code business (jnr-ffi/jnr-posix) which relies on asm,
and an added jackson dependency.
We could think about excluding `jnr-ffi`; afaict it is optional and uses who
want to use it can do so.
As for jackson, we should consider bundling&relocating it. But first we
should figure out what that is used for anyway; specifically whether it is a
purely internal dependency or also exposed somewhere in the API.
##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -36,9 +36,11 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
- <cassandra.version>2.2.5</cassandra.version>
- <driver.version>3.0.0</driver.version>
- <guava.version>18.0</guava.version>
+ <!-- Cassandra version 4.x allow to address clusters of version
3.x as well -->
+ <cassandra.version>4.0.3</cassandra.version>
+ <!--driver 3.x works with 3.x and 4.x versions of Cassandra but
driver 4.x is a complete refactoring with different API-->
+ <driver.version>3.11.2</driver.version>
+ <guava.version>19.0</guava.version>
Review Comment:
unused
##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -140,11 +142,11 @@ under the License.
<artifactId>scala-library</artifactId>
<scope>provided</scope>
</dependency>
- <dependency>
+<!-- <dependency>
Review Comment:
remove it instead
##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -36,9 +36,11 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
- <cassandra.version>2.2.5</cassandra.version>
- <driver.version>3.0.0</driver.version>
- <guava.version>18.0</guava.version>
+ <!-- Cassandra version 4.x allow to address clusters of version
3.x as well -->
+ <cassandra.version>4.0.3</cassandra.version>
+ <!--driver 3.x works with 3.x and 4.x versions of Cassandra but
driver 4.x is a complete refactoring with different API-->
+ <driver.version>3.11.2</driver.version>
Review Comment:
FYI cassandra also publishes a shaded jar of cassandra-core which already
bundles netty; could use that to reduce some complexity on our side.
##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -36,9 +36,11 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
- <cassandra.version>2.2.5</cassandra.version>
- <driver.version>3.0.0</driver.version>
- <guava.version>18.0</guava.version>
+ <!-- Cassandra version 4.x allow to address clusters of version
3.x as well -->
+ <cassandra.version>4.0.3</cassandra.version>
Review Comment:
unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
