dianfu commented on code in PR #19259:
URL: https://github.com/apache/flink/pull/19259#discussion_r893283251
##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/CepOperator.java:
##########
@@ -417,6 +405,9 @@ private void processEvent(NFAState nfaState, IN event, long
timestamp) throws Ex
timestamp,
afterMatchSkipStrategy,
cepTimerService);
+ if (nfa.getWindowTime() > 0 && nfaState.isNewStartPartialMatch()) {
+ registerTimer(timestamp + nfa.getWindowTime());
Review Comment:
Should we add the following code in `onProcessingTime`?
```
advanceTime(nfaState,timer.getTimestamp());
```
Otherwise, I'm afraid that the timer registered via `registerTimer(timestamp
+ nfa.getWindowTime())` will not trigger the nfa timed out in processing time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
