JingsongLi commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r893287683
########## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetUtil.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.format.parquet; + +import org.apache.flink.table.data.DecimalData; +import org.apache.flink.table.store.file.stats.FieldStats; +import org.apache.flink.table.types.logical.RowType; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.parquet.ParquetReadOptions; +import org.apache.parquet.column.statistics.BinaryStatistics; +import org.apache.parquet.column.statistics.IntStatistics; +import org.apache.parquet.column.statistics.LongStatistics; +import org.apache.parquet.column.statistics.Statistics; +import org.apache.parquet.hadoop.ParquetFileReader; +import org.apache.parquet.hadoop.metadata.BlockMetaData; +import org.apache.parquet.hadoop.metadata.ColumnChunkMetaData; +import org.apache.parquet.hadoop.metadata.ParquetMetadata; +import org.apache.parquet.hadoop.util.HadoopInputFile; +import org.apache.parquet.schema.PrimitiveType; + +import java.io.IOException; +import java.math.BigDecimal; +import java.math.BigInteger; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** parquet utility, support for extracting metadata and etc. */ +public class ParquetUtil { + + /** + * @param path the path of parquet files to be read + * @return result sets as map, key is column name, value is statistics (for example, null count, + * minimum value, maximum value) + * @throws IOException + */ + public static Map<String, Statistics> extractColumnStats(Path path) throws IOException { + ParquetMetadata parquetMetadata = getParquetReader(path).getFooter(); + List<BlockMetaData> blockMetaDataList = parquetMetadata.getBlocks(); + Map<String, Statistics> resultStats = new HashMap<>(); + for (BlockMetaData blockMetaData : blockMetaDataList) { + List<ColumnChunkMetaData> columnChunkMetaDataList = blockMetaData.getColumns(); + for (ColumnChunkMetaData columnChunkMetaData : columnChunkMetaDataList) { + Statistics stats = columnChunkMetaData.getStatistics(); + String columnName = columnChunkMetaData.getPath().toDotString(); + Statistics midStats; + if (!resultStats.containsKey(columnName)) { + midStats = stats; + } else { + midStats = resultStats.get(columnName); + midStats.mergeStatistics(stats); + } + resultStats.put(columnName, midStats); + } + } + return resultStats; + } + + /** + * @param path the path of parquet files to be read + * @return parquet reader, used for reading footer, status, etc. + * @throws IOException + */ + public static ParquetFileReader getParquetReader(Path path) throws IOException { + HadoopInputFile hadoopInputFile = HadoopInputFile.fromPath(path, new Configuration()); + return ParquetFileReader.open(hadoopInputFile, ParquetReadOptions.builder().build()); + } + + /** + * parquet cannot provide statistics for decimal fields directly, but we can extract them from + * primitive statistics. + */ + public static FieldStats convertStatsToDecimalFieldStats( Review Comment: This method should belong to `ParquetFileStatsExtractor`? ########## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileStatsExtractor.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.format.parquet; + +import org.apache.flink.core.fs.Path; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.store.file.stats.FieldStats; +import org.apache.flink.table.store.file.stats.FileStatsExtractor; +import org.apache.flink.table.types.logical.DecimalType; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.utils.DateTimeUtils; + +import org.apache.parquet.column.statistics.BinaryStatistics; +import org.apache.parquet.column.statistics.BooleanStatistics; +import org.apache.parquet.column.statistics.DoubleStatistics; +import org.apache.parquet.column.statistics.FloatStatistics; +import org.apache.parquet.column.statistics.IntStatistics; +import org.apache.parquet.column.statistics.LongStatistics; +import org.apache.parquet.column.statistics.Statistics; +import org.apache.parquet.schema.LogicalTypeAnnotation; +import org.apache.parquet.schema.PrimitiveType; + +import java.io.IOException; +import java.time.Instant; +import java.time.LocalDate; +import java.time.OffsetDateTime; +import java.time.ZoneOffset; +import java.util.Map; +import java.util.stream.IntStream; + +import static org.apache.flink.table.store.format.parquet.ParquetUtil.assertStatsClass; +import static org.apache.flink.table.store.format.parquet.ParquetUtil.convertStatsToDecimalFieldStats; + +/** {@link FileStatsExtractor} for parquet files. */ +public class ParquetFileStatsExtractor implements FileStatsExtractor { + + private final RowType rowType; + private static final OffsetDateTime EPOCH = Instant.ofEpochSecond(0).atOffset(ZoneOffset.UTC); + private static final LocalDate EPOCH_DAY = EPOCH.toLocalDate(); + + public ParquetFileStatsExtractor(RowType rowType) { + this.rowType = rowType; + } + + @Override + public FieldStats[] extract(Path path) throws IOException { + org.apache.hadoop.fs.Path hadoopPath = new org.apache.hadoop.fs.Path(path.toUri()); + Map<String, Statistics> stats = ParquetUtil.extractColumnStats(hadoopPath); + + return IntStream.range(0, rowType.getFieldCount()) + .mapToObj( + i -> { + RowType.RowField field = rowType.getFields().get(i); + return toFieldStats(field, stats.get(field.getName())); + }) + .toArray(FieldStats[]::new); + } + + private FieldStats toFieldStats(RowType.RowField field, Statistics stats) { + LogicalTypeRoot flinkType = field.getType().getTypeRoot(); + if (stats == null + || flinkType == LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE + || flinkType == LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) { + throw new UnsupportedOperationException( + "type " + + field.getType().getTypeRoot() + + " not supported for extracting statistics in parquet format"); + } + long nullCount = stats.getNumNulls(); + if (!stats.hasNonNullValue()) { + return new FieldStats(null, null, nullCount); + } + + switch (flinkType) { + case CHAR: + case VARCHAR: + assertStatsClass(field, stats, BinaryStatistics.class); + BinaryStatistics binaryStats = (BinaryStatistics) stats; + return new FieldStats( + StringData.fromString(binaryStats.minAsString()), + StringData.fromString(binaryStats.maxAsString()), + nullCount); + case BOOLEAN: + assertStatsClass(field, stats, BooleanStatistics.class); + BooleanStatistics boolStats = (BooleanStatistics) stats; + return new FieldStats(boolStats.getMin(), boolStats.getMax(), nullCount); + case DECIMAL: + PrimitiveType primitive = stats.type(); + DecimalType decimalType = (DecimalType) (field.getType()); + int precision = decimalType.getPrecision(); + int scale = decimalType.getScale(); + if (primitive.getOriginalType() != null + && primitive.getLogicalTypeAnnotation() + instanceof LogicalTypeAnnotation.DecimalLogicalTypeAnnotation) { + return convertStatsToDecimalFieldStats( + primitive, field, stats, precision, scale, nullCount); + } else { + return new FieldStats(null, null, nullCount); Review Comment: What will be the situation here? ########## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileStatsExtractor.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.format.parquet; + +import org.apache.flink.core.fs.Path; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.store.file.stats.FieldStats; +import org.apache.flink.table.store.file.stats.FileStatsExtractor; +import org.apache.flink.table.types.logical.DecimalType; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.utils.DateTimeUtils; + +import org.apache.parquet.column.statistics.BinaryStatistics; +import org.apache.parquet.column.statistics.BooleanStatistics; +import org.apache.parquet.column.statistics.DoubleStatistics; +import org.apache.parquet.column.statistics.FloatStatistics; +import org.apache.parquet.column.statistics.IntStatistics; +import org.apache.parquet.column.statistics.LongStatistics; +import org.apache.parquet.column.statistics.Statistics; +import org.apache.parquet.schema.LogicalTypeAnnotation; +import org.apache.parquet.schema.PrimitiveType; + +import java.io.IOException; +import java.time.Instant; +import java.time.LocalDate; +import java.time.OffsetDateTime; +import java.time.ZoneOffset; +import java.util.Map; +import java.util.stream.IntStream; + +import static org.apache.flink.table.store.format.parquet.ParquetUtil.assertStatsClass; +import static org.apache.flink.table.store.format.parquet.ParquetUtil.convertStatsToDecimalFieldStats; + +/** {@link FileStatsExtractor} for parquet files. */ +public class ParquetFileStatsExtractor implements FileStatsExtractor { + + private final RowType rowType; + private static final OffsetDateTime EPOCH = Instant.ofEpochSecond(0).atOffset(ZoneOffset.UTC); + private static final LocalDate EPOCH_DAY = EPOCH.toLocalDate(); + + public ParquetFileStatsExtractor(RowType rowType) { + this.rowType = rowType; + } + + @Override + public FieldStats[] extract(Path path) throws IOException { + org.apache.hadoop.fs.Path hadoopPath = new org.apache.hadoop.fs.Path(path.toUri()); + Map<String, Statistics> stats = ParquetUtil.extractColumnStats(hadoopPath); + + return IntStream.range(0, rowType.getFieldCount()) + .mapToObj( + i -> { + RowType.RowField field = rowType.getFields().get(i); + return toFieldStats(field, stats.get(field.getName())); + }) + .toArray(FieldStats[]::new); + } + + private FieldStats toFieldStats(RowType.RowField field, Statistics stats) { + LogicalTypeRoot flinkType = field.getType().getTypeRoot(); + if (stats == null + || flinkType == LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE + || flinkType == LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) { + throw new UnsupportedOperationException( Review Comment: Does this mean that we can not support timestamp type for parquet now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
