Aitozi commented on code in PR #260:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/260#discussion_r893219001
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java:
##########
@@ -31,23 +36,29 @@
import java.util.concurrent.TimeoutException;
/** An observer to observe the job status. */
-public abstract class JobStatusObserver<CTX> {
+public abstract class JobStatusObserver<
+ SPEC extends AbstractFlinkSpec, STATUS extends CommonStatus<SPEC>,
CTX> {
private static final Logger LOG =
LoggerFactory.getLogger(JobStatusObserver.class);
+ private static final int MAX_ERROR_STRING_LENGTH = 512;
private final FlinkService flinkService;
+ private final KubernetesClient kubernetesClient;
- public JobStatusObserver(FlinkService flinkService) {
+ public JobStatusObserver(FlinkService flinkService, KubernetesClient
client) {
this.flinkService = flinkService;
+ this.kubernetesClient = client;
Review Comment:
hah, thanks for remind. I did't notice that just now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
