gyfora commented on code in PR #260:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/260#discussion_r893167124
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/ApplicationObserver.java:
##########
@@ -82,11 +79,14 @@ protected boolean observeFlinkCluster(
var jobStatus = flinkApp.getStatus().getJobStatus();
+ var previousJobState = jobStatus.getState();
boolean jobFound =
jobStatusObserver.observe(
- jobStatus,
+ flinkApp.getStatus(),
deployedConfig,
new ApplicationObserverContext(flinkApp, context,
deployedConfig));
+ EventUtils.generateEventsOnJobStatusChanged(
+ kubernetesClient, previousJobState, jobStatus, flinkApp);
Review Comment:
Wouldn't it be enough to simply change the jobstatus observer to get the
full resource object instead of the status only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
