MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857867821
########## docs/go.mod: ########## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406114754-ce4058113b37 // indirect + github.com/apache/flink-connector-elasticsearch/docs v0.0.0-20220425092437-8e4b91cb3984 // indirect Review Comment: ~~I think we can actually live without this. When the documentation is built, it will be added by Hugo to this file, but it's not a prerequisite. If it's not there, it will just pull the latest, which is actually what we want.~~ Curious on your opinion: we don't need it, if it's not there, Hugo will just pull the latest version (which is what we want). The documentation build pipeline specifies the branch, so that would work too I think. However, adding this file to `.gitignore` would mean an extra step if we would like to do something like update the Go version (because the file won't be checked in anymore). What do you think we could do best? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
