zentol commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r857616436
########## docs/go.mod: ########## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406114754-ce4058113b37 // indirect + github.com/apache/flink-connector-elasticsearch/docs v0.0.0-20220425092437-8e4b91cb3984 // indirect Review Comment: does it really make to commit such a go.mod file? aren't the date/sha references gonna change all the time? ########## docs/go.mod: ########## @@ -0,0 +1,8 @@ +module github.com/apache/flink + +go 1.18 + +require ( + github.com/apache/flink-connector-elasticsearch v0.0.0-20220406114754-ce4058113b37 // indirect + github.com/apache/flink-connector-elasticsearch/docs v0.0.0-20220425092437-8e4b91cb3984 // indirect Review Comment: does it really make sense to commit such a go.mod file? aren't the date/sha references gonna change all the time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
