Myasuka commented on a change in pull request #18840:
URL: https://github.com/apache/flink/pull/18840#discussion_r816423068
##########
File path:
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/output/SnapshotUtilsTest.java
##########
@@ -50,13 +53,24 @@
private static final List<String> ACTUAL_ORDER_TRACKING =
Collections.synchronizedList(new
ArrayList<>(EXPECTED_CALL_OPERATOR_SNAPSHOT.size()));
+ private static SnapshotType actualSnapshotType;
+
@Test
public void testSnapshotUtilsLifecycle() throws Exception {
+
testSnapshotUtilsLifecycleWithSavepointFormatType(SavepointFormatType.DEFAULT);
+
testSnapshotUtilsLifecycleWithSavepointFormatType(SavepointFormatType.NATIVE);
Review comment:
In general, we should only use one unit test case for one specific test
purpose. It's better to split this test case into two cases, one is testing
`SavepointFormatType.DEFAULT` and another is for `SavepointFormatType.NATIVE`.
Moreover, I also suggest to test `SavepointFormatType.CANONICAL` instead of
`SavepointFormatType.DEFAULT` in case we might change the
`SavepointFormatType.DEFAULT` to `SavepointFormatType.NATIVE` in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
