Myasuka commented on a change in pull request #18840:
URL: https://github.com/apache/flink/pull/18840#discussion_r815634090
##########
File path:
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/output/SnapshotUtilsTest.java
##########
@@ -52,6 +53,7 @@
@Test
public void testSnapshotUtilsLifecycle() throws Exception {
+ ACTUAL_ORDER_TRACKING.clear();
Review comment:
How about introduce a `@Before` method to clear the
`ACTUAL_ORDER_TRACKING`?
##########
File path:
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/output/SnapshotUtilsTest.java
##########
@@ -60,6 +62,25 @@ public void testSnapshotUtilsLifecycle() throws Exception {
Assert.assertEquals(EXPECTED_CALL_OPERATOR_SNAPSHOT,
ACTUAL_ORDER_TRACKING);
}
+ @Test
+ public void testSnapshotUtilsLifecycleWithNativeSavepoint() throws
Exception {
Review comment:
I don't think this test actually test the snapshot type. I think we can
recored the `snapshotType` in `LifecycleOperator#snapshotState` method, and
then verify that we have passed the native savepoint snapshot type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
