[ 
https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423388#comment-15423388
 ] 

ASF GitHub Bot commented on FLINK-3950:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2374
  
    Good work! Only found a minor issue in regards to the TestingMeter class.
    
    There is one thing I would like to start a discussion on however. Right now 
the Meter interface is essentially a copy of the DropWizard Meter interface, 
which is a fair starting point. 
    
    Now my question is: does this fit our use case?  For example, should we 
really mandate exponentially weighed rate (according to the javadocs), or do we 
really need the 15 minute rate?


> Add Meter Metric Type
> ---------------------
>
>                 Key: FLINK-3950
>                 URL: https://issues.apache.org/jira/browse/FLINK-3950
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Ivan Mushketyk
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to