[ 
https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420743#comment-15420743
 ] 

Chesnay Schepler commented on FLINK-3950:
-----------------------------------------

The idea behind the Meter view is to reduce the overhead on the processing 
thread.

For example, when using a DropWizard meter for every event you update 4 
LongAdders, and regularly calculate the 3 different rates, all with thread-safe 
classes. This is all done by the same thread that does the actual processing. 
The overhead when doing this thousands of times per second adds up.

A meter view on the other hand works behind the scenes. A user would register a 
counter and a view, but would only use the counter (==very cheap). The view is 
updated by a background thread in regular intervals, calculating rates based on 
the counter's values.

However, having a standalone meter type is quite useful. For example in regards 
to compatibility; there will be users who already use dropwizard meters and 
can't just replace them with our metrics.

As such i would propose the following

[~ivan.mushketyk] implements the standalone Meter. This includes the Meter 
interface (I'm not quite sure which rates it should calculate right now), a 
wrapper for DropWizard meters, (similar to histograms), proper propagation 
through the metric system and handling by reporters.

The View implementation will be done by me. I'm starting to think that Views 
and Meters will be separate things in the end, so there shouldn't be much 
overlap.

Would that be alright with you [~ivan.mushketyk]?

> Add Meter Metric Type
> ---------------------
>
>                 Key: FLINK-3950
>                 URL: https://issues.apache.org/jira/browse/FLINK-3950
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Ivan Mushketyk
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to