tsreaper commented on a change in pull request #14: URL: https://github.com/apache/flink-table-store/pull/14#discussion_r791589339
########## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreScan.java ########## @@ -31,6 +32,8 @@ FileStoreScan withPartitionFilter(Predicate predicate); + FileStoreScan withPartitionFilter(List<BinaryRowData> partitions); Review comment: No need. If I want to filter out partitions I would change the method name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org