tsreaper commented on a change in pull request #14:
URL: https://github.com/apache/flink-table-store/pull/14#discussion_r791536162
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/FileStorePathFactory.java
##########
@@ -106,10 +115,12 @@ public SstPathFactory createSstPathFactory(BinaryRowData
partition, int bucket)
}
public String getPartitionString(BinaryRowData partition) {
- return PartitionPathUtils.generatePartitionPath(
- partitionComputer.generatePartValues(
- Preconditions.checkNotNull(
- partition, "Partition row data is null. This
is unexpected.")));
+ synchronized (partitionComputer) {
Review comment:
Because we have to make sure that this class is thread safe. Partition
computer is not thread safe.
Another option is to create a read-only path factory which only supports a
limited number of methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
