JingsongLi commented on a change in pull request #18394:
URL: https://github.com/apache/flink/pull/18394#discussion_r788355740



##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -145,6 +145,19 @@ under the License.
                        <scope>test</scope>
                        <type>test-jar</type>
                </dependency>
+               <dependency>

Review comment:
       > TestManagedFactory can be removed from 
org.apache.flink.table.factories.Factory file under the table-planner module to 
avoid adding a test-jar dependency. 
   
   Where? Can you clarify where the changes led here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to