JingsongLi commented on a change in pull request #18394:
URL: https://github.com/apache/flink/pull/18394#discussion_r788353676
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SourceQueryOperation.java
##########
@@ -39,9 +39,16 @@
public class SourceQueryOperation implements QueryOperation {
private final ContextResolvedTable contextResolvedTable;
+ private final Map<String, String> dynamicOptions;
public SourceQueryOperation(ContextResolvedTable contextResolvedTable) {
+ this(contextResolvedTable, Collections.emptyMap());
+ }
+
+ public SourceQueryOperation(
+ ContextResolvedTable contextResolvedTable, Map<String, String>
dynamicOptions) {
Review comment:
I feel it is better to use Nullable. `scan(t)` and `scan(t,
dynamicOptions)` are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
