MartijnVisser commented on pull request #18151:
URL: https://github.com/apache/flink/pull/18151#issuecomment-998025481


   > The expectation that a query with `LIMIT` always returns the same results 
is only true for ordered output, which streaming queries don't support to begin 
with.
   
   For me the question is what a user expects when its applying LIMIT. The fact 
we don't (yet) support it is less relevant in that context. Is there anything 
on LIMIT in the SQL standards? 
   
   > I don't see a great reason why the datagen connector should need to 
support this, but I certainly don't see harm in it either.
   
   The harm I see is that we have two options to achieve apparently the same 
result, which could also be conflicting with each other ("What output can I 
expect when I set `number-of-rows` to 10 and `LIMIT 5`")?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to