Airblader commented on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-998009452
The expectation that a query with `LIMIT` always returns the same results is only true for ordered output, which streaming queries don't support to begin with. I don't think the comparison to the Kafka connector is correct here; having to specify a fixed offset is an additional requirement (not mandated by the Kafka connector), and a similar thing could be done for datagen (specifying a seed for the RNG). Let's keep in mind that the limit _is already_ being applied, by Flink itself outside the source. The pushdown just allows the source itself to aid with that. I don't see a great reason why the datagen connector should need to support this, but I certainly don't see harm in it either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org