matriv commented on a change in pull request #17634:
URL: https://github.com/apache/flink/pull/17634#discussion_r744574484



##########
File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeMerging.java
##########
@@ -301,6 +301,16 @@ public static LogicalType findSumAggType(LogicalType 
argType) {
      * integral part of a result from being truncated.
      *
      * 
<p>https://docs.microsoft.com/en-us/sql/t-sql/data-types/precision-scale-and-length-transact-sql
+     *
+     * <p>The rules although inspired by SQL Server they are not followed 
100%, instead the approach

Review comment:
       fixed, also added more explanation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to