[GitHub] [flink] matriv commented on a change in pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

[GitBox]

matriv commented on a change in pull request #17634:
URL: https://github.com/apache/flink/pull/17634#discussion_r744115543



##########
File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/SumAggFunction.java
##########
@@ -66,7 +66,10 @@ public int operandCount() {
                     ifThenElse(
                             isNull(operand(0)),
                             sum,
-                            ifThenElse(isNull(sum), operand(0), plus(sum, 
operand(0)))))
+                            ifThenElse(

Review comment:
       Thank you @cshuo, Implemented a new `plusSum` operator and improved the 
tests. Please check again.
   Additionally I've created 
[FLINK-24809](https://issues.apache.org/jira/browse/FLINK-24809) to check and 
fix the rest of the aggregate functions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org